# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE # Copyright (c) https://github.com/PyCQA/pylint/blob/main/CONTRIBUTORS.txt from __future__ import annotations from typing import TYPE_CHECKING from astroid import nodes from pylint.checkers import BaseChecker from pylint.interfaces import HIGH if TYPE_CHECKING: from pylint.lint import PyLinter COMPARISON_OP = frozenset(("<", "<=", ">", ">=", "!=", "==")) IDENTITY_OP = frozenset(("is", "is not")) MEMBERSHIP_OP = frozenset(("in", "not in")) class BadChainedComparisonChecker(BaseChecker): """Checks for unintentional usage of chained comparison.""" name = "bad-chained-comparison" msgs = { "W3601": ( "Suspicious %s-part chained comparison using semantically incompatible operators (%s)", "bad-chained-comparison", "Used when there is a chained comparison where one expression is part " "of two comparisons that belong to different semantic groups " '("<" does not mean the same thing as "is", chaining them in ' '"0 < x is None" is probably a mistake).', ) } def _has_diff_semantic_groups(self, operators: list[str]) -> bool: # Check if comparison operators are in the same semantic group for semantic_group in (COMPARISON_OP, IDENTITY_OP, MEMBERSHIP_OP): if operators[0] in semantic_group: group = semantic_group return not all(o in group for o in operators) def visit_compare(self, node: nodes.Compare) -> None: operators = sorted({op[0] for op in node.ops}) if self._has_diff_semantic_groups(operators): num_parts = f"{len(node.ops)}" incompatibles = ( ", ".join(f"'{o}'" for o in operators[:-1]) + f" and '{operators[-1]}'" ) self.add_message( "bad-chained-comparison", node=node, args=(num_parts, incompatibles), confidence=HIGH, ) def register(linter: PyLinter) -> None: linter.register_checker(BadChainedComparisonChecker(linter))
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
__pycache__ | Folder | 0755 |
|
|
base | Folder | 0755 |
|
|
classes | Folder | 0755 |
|
|
refactoring | Folder | 0755 |
|
|
__init__.py | File | 4.26 KB | 0644 |
|
async.py | File | 3.83 KB | 0644 |
|
bad_chained_comparison.py | File | 2.18 KB | 0644 |
|
base_checker.py | File | 10.67 KB | 0644 |
|
deprecated.py | File | 9.43 KB | 0644 |
|
design_analysis.py | File | 21.62 KB | 0644 |
|
dunder_methods.py | File | 3.43 KB | 0644 |
|
ellipsis_checker.py | File | 1.97 KB | 0644 |
|
exceptions.py | File | 26.05 KB | 0644 |
|
format.py | File | 26.91 KB | 0644 |
|
imports.py | File | 41.31 KB | 0644 |
|
lambda_expressions.py | File | 3.38 KB | 0644 |
|
logging.py | File | 15.84 KB | 0644 |
|
mapreduce_checker.py | File | 1.08 KB | 0644 |
|
method_args.py | File | 4.68 KB | 0644 |
|
misc.py | File | 4.87 KB | 0644 |
|
modified_iterating_checker.py | File | 7.67 KB | 0644 |
|
nested_min_max.py | File | 3.63 KB | 0644 |
|
newstyle.py | File | 4.46 KB | 0644 |
|
non_ascii_names.py | File | 6.98 KB | 0644 |
|
raw_metrics.py | File | 3.81 KB | 0644 |
|
similar.py | File | 33.29 KB | 0644 |
|
spelling.py | File | 16.17 KB | 0644 |
|
stdlib.py | File | 31.28 KB | 0644 |
|
strings.py | File | 40.28 KB | 0644 |
|
threading_checker.py | File | 1.9 KB | 0644 |
|
typecheck.py | File | 86.83 KB | 0644 |
|
unicode.py | File | 18.05 KB | 0644 |
|
unsupported_version.py | File | 2.93 KB | 0644 |
|
utils.py | File | 77.26 KB | 0644 |
|
variables.py | File | 126.57 KB | 0644 |
|